Skip to content

DR: backup etcd env file during snapshot restore#791

Closed
vrutkovs wants to merge 1 commit intoopenshift:masterfrom
vrutkovs:dr-missing-etcd-env
Closed

DR: backup etcd env file during snapshot restore#791
vrutkovs wants to merge 1 commit intoopenshift:masterfrom
vrutkovs:dr-missing-etcd-env

Conversation

@vrutkovs
Copy link
Contributor

@vrutkovs vrutkovs commented May 23, 2019 •
edited
Loading

During snapshot restore this file may be deleted when pods are stopped,
so restore_snapshot should use backed up copy of this file

/cc @hexfusion @runcom

DR: backup etcd env file during snapshot restore
97ba31b 
During snapshot restore this file may be deleted when pods are stopped, 
so restore_snapshot should use backed up copy of this file
@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 23, 2019
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 23, 2019

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: vrutkovs
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: runcom

If they are not already assigned, you can assign the PR to them by writing /assign @runcom in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vrutkovs vrutkovs mentioned this pull request May 23, 2019
Merged
6 tasks
@vrutkovs
Copy link
Contributor Author

vrutkovs commented May 23, 2019

/retest

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 23, 2019

@vrutkovs: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-aws-upgrade 97ba31b link /test e2e-aws-upgrade

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hexfusion
Copy link
Contributor

hexfusion commented May 23, 2019

/hold

@vrutkovs see if #793 resolves your problem. In the case that DNS somehow changes I think I would rather validate against DNS vs use backup if possible. Let me know your thoughts.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 23, 2019
@vrutkovs
Copy link
Contributor Author

vrutkovs commented May 24, 2019

Closing as #793 is a better solution to the same problem - /run/etcd/environment would be generated if it doesn't exist

@vrutkovs vrutkovs closed this May 24, 2019
@vrutkovs vrutkovs deleted the dr-missing-etcd-env branch May 24, 2019 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cgwalters cgwalters Awaiting requested review from cgwalters

@kikisdeliveryservice kikisdeliveryservice Awaiting requested review from kikisdeliveryservice

Assignees

No one assigned

Labels

do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vrutkovs @openshift-ci-robot @hexfusion